@cursor review that changes are similar to #2912 carefully look for changes out of the PR scope.

Client V2 Coverage

Coverage Report

JDBC V2 Coverage

Coverage Report

JDBC V1 Coverage

Coverage Report

Client V1 Coverage

Coverage Report

Triage

Category: feature • Risk: high

Summary
This PR merges the release_0.10.0 branch into main, introducing client-side request cancellation for client-v2. It adds two new internal interfaces (TransportRequest, TransportResponse) and refactors HttpAPIClientHelper to split request creation (createRequest) from execution (executeRequest), threading a ConcurrentHashMap-backed registry through all operation paths (query, insert) so that an in-flight request can be aborted via the new public method Client#cancelTransportRequest(String queryId). Alongside the cancellation feature, the PR also changes the HTTP error-classification logic: 503 responses are reclassified from ServerRetryable to ConnectTimeout (surfaced as ConnectionInitiationException), and unknown status codes now throw ClientException instead of ServerException. A large batch of integration and unit tests covers the retry paths, cancellation lifecycle, and the 503 reclassification.

What this impacts

• client-v2 core — Client.java, HttpAPIClientHelper.java, InsertResponse, QueryResponse, all operation execution paths
• New internal transport abstraction layer (com.clickhouse.client.api.transport.internal)
• Public API surface: new Client#cancelTransportRequest(String queryId) method; InsertResponse and QueryResponse constructor signatures changed (old overloads removed)
• Exception-handling contracts: callers catching ServerException on 503 or unknown status codes will silently change behavior

Concerns

• Large diff rule fires: 1,530 lines added / 209 deleted — well above the 400-line threshold. PR is flagged risk:high by the repo already; consider requesting a split between the transport-refactor, the 503 reclassification, and the new cancellation API.
• Public API breaking change: InsertResponse(OperationMetrics, Map) and QueryResponse(ClassicHttpResponse, ...) constructors are removed and replaced with new signatures accepting TransportResponse. Callers who construct these directly (e.g. in tests or downstream wrappers) will have source-level breakage.
• Behavioral exception-contract change: 503 previously surfaced as ServerException under ServerRetryable; it now surfaces as ConnectionInitiationException under ConnectTimeout. Unknown HTTP codes previously threw ServerException; they now throw ClientException. Both are documented in the CHANGELOG but are observable breaking changes for callers who branch on exception type or fault cause.
• Cancel-registry race on retry: unregisterTransportReq is called in the finally block of each loop iteration, then a new TransportRequest is registered at the top of the next iteration. A cancelTransportRequest call that arrives between unregisterTransportReq and the subsequent registerTransportReq will silently miss the in-progress retry — the next attempt will run uncancelled. Whether this is intentional should be confirmed.

Required reviewer action

• At least one human reviewer.

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

💡 Need a hand with PR review? Try Gitar by Sonar!